Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Integrate feedback from code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1827 matching lines...) Expand 10 before | Expand all | Expand 10 after
1838 LDateField* result = 1838 LDateField* result =
1839 new(zone()) LDateField(date, FixedTemp(ecx), instr->index()); 1839 new(zone()) LDateField(date, FixedTemp(ecx), instr->index());
1840 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY); 1840 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY);
1841 } 1841 }
1842 1842
1843 1843
1844 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1844 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1845 LOperand* string = UseRegister(instr->string()); 1845 LOperand* string = UseRegister(instr->string());
1846 LOperand* index = UseRegister(instr->index()); 1846 LOperand* index = UseRegister(instr->index());
1847 ASSERT(ecx.is_byte_register()); 1847 ASSERT(ecx.is_byte_register());
1848 // TODO(titzer): the machine code for this instruction overwrites ecx! fix!
1848 LOperand* value = UseFixed(instr->value(), ecx); 1849 LOperand* value = UseFixed(instr->value(), ecx);
1849 LSeqStringSetChar* result = 1850 LSeqStringSetChar* result =
1850 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value); 1851 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);
1851 return DefineSameAsFirst(result); 1852 return DefineSameAsFirst(result);
1852 } 1853 }
1853 1854
1854 1855
1855 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) { 1856 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) {
1856 return NULL; 1857 return NULL;
1857 } 1858 }
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
2758 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2759 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2759 LOperand* object = UseRegister(instr->object()); 2760 LOperand* object = UseRegister(instr->object());
2760 LOperand* index = UseTempRegister(instr->index()); 2761 LOperand* index = UseTempRegister(instr->index());
2761 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2762 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2762 } 2763 }
2763 2764
2764 2765
2765 } } // namespace v8::internal 2766 } } // namespace v8::internal
2766 2767
2767 #endif // V8_TARGET_ARCH_IA32 2768 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698