Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Integrate feedback from code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 PrintDataTo(stream); 799 PrintDataTo(stream);
800 PrintRangeTo(stream); 800 PrintRangeTo(stream);
801 PrintChangesTo(stream); 801 PrintChangesTo(stream);
802 PrintTypeTo(stream); 802 PrintTypeTo(stream);
803 if (CheckFlag(HValue::kHasNoObservableSideEffects)) { 803 if (CheckFlag(HValue::kHasNoObservableSideEffects)) {
804 stream->Add(" [noOSE]"); 804 stream->Add(" [noOSE]");
805 } 805 }
806 } 806 }
807 807
808 808
809 void HInstruction::PrintDataTo(StringStream *stream) {
810 for (int i = 0; i < OperandCount(); ++i) {
811 if (i > 0) stream->Add(" ");
812 OperandAt(i)->PrintNameTo(stream);
813 }
814 }
815
816
809 void HInstruction::PrintMnemonicTo(StringStream* stream) { 817 void HInstruction::PrintMnemonicTo(StringStream* stream) {
810 stream->Add("%s ", Mnemonic()); 818 stream->Add("%s ", Mnemonic());
811 } 819 }
812 820
813 821
814 void HInstruction::Unlink() { 822 void HInstruction::Unlink() {
815 ASSERT(IsLinked()); 823 ASSERT(IsLinked());
816 ASSERT(!IsControlInstruction()); // Must never move control instructions. 824 ASSERT(!IsControlInstruction()); // Must never move control instructions.
817 ASSERT(!IsBlockEntry()); // Doesn't make sense to delete these. 825 ASSERT(!IsBlockEntry()); // Doesn't make sense to delete these.
818 ASSERT(previous_ != NULL); 826 ASSERT(previous_ != NULL);
(...skipping 2835 matching lines...) Expand 10 before | Expand all | Expand 10 after
3654 3662
3655 3663
3656 void HCheckFunction::Verify() { 3664 void HCheckFunction::Verify() {
3657 HInstruction::Verify(); 3665 HInstruction::Verify();
3658 ASSERT(HasNoUses()); 3666 ASSERT(HasNoUses());
3659 } 3667 }
3660 3668
3661 #endif 3669 #endif
3662 3670
3663 } } // namespace v8::internal 3671 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698