Unify alloca, outgoing arg, and prolog construction

1) Move helper creation to separate method, which also computes the maximum outgoing argument size.  The computed size is checked against call lowering's size.
2) Make addProlog use the outgoing argument size and remove the adjustments in lowerCall.
3) Remove AdjustStack instructions and friends.

BUG=
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=26217e3333150e66fc96aca79c01105906797960

[sehr, 2015-11-24 21:33:29]

Description was changed from

==========
Move helper creation to separate method

BUG=
==========

to

==========
Move helper creation to separate method, which also computes the maximum
outgoing argument size.  The computed size is checked against call lowering's
size, but is not yet used for stack frame allocation.

BUG=
==========

[sehr, 2015-11-24 21:33:29]

sehr@chromium.org changed reviewers:
+ jpp@chromium.org, stichnot@chromium.org

[sehr, 2015-11-24 21:33:44]

Not happy with the naming of this function, but PTAL.

[sehr, 2015-11-24 21:43:34]

Never mind for now.  Conflicted with jpp's CL.  Will notify when ready.

[John, 2015-11-24 22:25:48]

lgtm

[sehr, 2015-11-25 07:40:44]

Description was changed from

==========
Move helper creation to separate method, which also computes the maximum
outgoing argument size.  The computed size is checked against call lowering's
size, but is not yet used for stack frame allocation.

BUG=
==========

to

==========
1) Move helper creation to separate method, which also computes the maximum
outgoing argument size.  The computed size is checked against call lowering's
size.
2) Make addProlog use the outgoing argument size and remove the adjustments in
lowerCall.
3) Remove AdjustStack instructions and friends.

BUG=
==========

[sehr, 2015-11-25 20:22:29]

Presubmit now passes -- and we've gone the whole way to have fixed allocas and
outgoing args reserved in the prolog/epilog.

PTAL.

[Jim Stichnoth, 2015-11-26 18:32:06]

LGTM.

You may want to get rid of TargetLowering::StackAdjustment as well.

I think you need to update the CL description to include the title string "Unify
alloca, outgoing arg, and prolog construction."

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX8632.cpp (right):

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
src/IceTargetLoweringX8632.cpp:506: if (!NeedsStackAlignment) {
Instead of "if (!c) a; else b;", use "if (c) b; else a;".

Same for the x8664 file.

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:5499: if (ReturnType == IceType_void)
This void test is redundant with the code below, can it be removed?

[sehr, 2015-11-26 21:03:54]

Description was changed from

==========
1) Move helper creation to separate method, which also computes the maximum
outgoing argument size.  The computed size is checked against call lowering's
size.
2) Make addProlog use the outgoing argument size and remove the adjustments in
lowerCall.
3) Remove AdjustStack instructions and friends.

BUG=
==========

to

==========
1) Move helper creation to separate method, which also computes the maximum
outgoing argument size.  The computed size is checked against call lowering's
size.
2) Make addProlog use the outgoing argument size and remove the adjustments in
lowerCall.
3) Remove AdjustStack instructions and friends.

BUG=
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[sehr, 2015-11-26 21:03:55]

Committed patchset #6 (id:100001) manually as
26217e3333150e66fc96aca79c01105906797960 (presubmit successful).

[sehr, 2015-11-26 21:09:23]

Thanks for the reviews.

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX8632.cpp (right):

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
src/IceTargetLoweringX8632.cpp:506: if (!NeedsStackAlignment) {
On 2015/11/26 18:32:06, stichnot wrote:
> Instead of "if (!c) a; else b;", use "if (c) b; else a;".
> 
> Same for the x8664 file.

I did it to parallel ARM.  I fixed that also.

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1472623002/diff/80001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:5499: if (ReturnType == IceType_void)
On 2015/11/26 18:32:06, stichnot wrote:
> This void test is redundant with the code below, can it be removed?

Removed.