Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/IceInstX86Base.h

Issue 1472623002: Unify alloca, outgoing arg, and prolog construction (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review fixes. Also removed StackAdjustment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstX8664.cpp ('k') | src/IceInstX86BaseImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstX86Base.h
diff --git a/src/IceInstX86Base.h b/src/IceInstX86Base.h
index 96dc1a7cfc2259654f46f4ca2d00b873b9a8d0e0..6e9d7bad4a27d01ddf27dd8f8d646949ad53a272 100644
--- a/src/IceInstX86Base.h
+++ b/src/IceInstX86Base.h
@@ -405,33 +405,6 @@ private:
InstX86Jmp(Cfg *Func, Operand *Target);
};
-/// AdjustStack instruction - grows the stack (moves esp down) by the given
-/// amount. If the amount is negative, it shrinks the stack (moves esp up).
-/// It also updates the target lowering StackAdjustment during code emission.
-template <class Machine>
-class InstX86AdjustStack final : public InstX86Base<Machine> {
- InstX86AdjustStack() = delete;
- InstX86AdjustStack(const InstX86AdjustStack &) = delete;
- InstX86AdjustStack &operator=(const InstX86AdjustStack &) = delete;
-
-public:
- static InstX86AdjustStack *create(Cfg *Func, int32_t Amount, Variable *Esp) {
- return new (Func->allocate<InstX86AdjustStack>())
- InstX86AdjustStack(Func, Amount, Esp);
- }
- void emit(const Cfg *Func) const override;
- void emitIAS(const Cfg *Func) const override;
- void dump(const Cfg *Func) const override;
- static bool classof(const Inst *Inst) {
- return InstX86Base<Machine>::isClassof(Inst,
- InstX86Base<Machine>::Adjuststack);
- }
-
-private:
- InstX86AdjustStack(Cfg *Func, int32_t Amount, Variable *Esp);
- const int32_t Amount;
-};
-
/// Call instruction. Arguments should have already been pushed.
template <class Machine> class InstX86Call final : public InstX86Base<Machine> {
InstX86Call() = delete;
@@ -2791,7 +2764,6 @@ template <class Machine> struct Insts {
using FakeRMW = InstX86FakeRMW<Machine>;
using Label = InstX86Label<Machine>;
- using AdjustStack = InstX86AdjustStack<Machine>;
using Call = InstX86Call<Machine>;
using Br = InstX86Br<Machine>;
« no previous file with comments | « src/IceInstX8664.cpp ('k') | src/IceInstX86BaseImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698