src/IceInstARM32.cpp - Issue 1472623002: Unify alloca, outgoing arg, and prolog construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.cpp

Issue 1472623002: Unify alloca, outgoing arg, and prolog construction (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review fixes. Also removed StackAdjustment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.cpp

diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp

index 24a9e0bbd8f4a506f4a488b5c6f1ead4bfcfe702..2c2b210e11eb2821e02a134953a03b0c50e791dd 100644

--- a/src/IceInstARM32.cpp

+++ b/src/IceInstARM32.cpp

@@ -975,7 +975,6 @@ void InstARM32Call::emit(const Cfg *Func) const {

<< "\t";

getCallTarget()->emit(Func);

}

- Func->getTarget()->resetStackAdjustment();

}

void InstARM32Call::emitIAS(const Cfg *Func) const {

@@ -995,7 +994,6 @@ void InstARM32Call::emitIAS(const Cfg *Func) const {

}

if (Asm->needsTextFixup())

return emitUsingTextFixup(Func);

- Func->getTarget()->resetStackAdjustment();

}

void InstARM32Call::dump(const Cfg *Func) const {

« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceInstX8632.cpp » ('j') | no next file with comments »