Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14694010: Consolidate manifest handler registration. (Closed)

Created:
7 years, 7 months ago by Yoyo Zhou
Modified:
7 years, 7 months ago
Reviewers:
Devlin, Matt Perry, sky
CC:
chromium-reviews, dtseng+watch_chromium.org, vsevik, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, pam+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, yurys, sail+watch_chromium.org, chromium-apps-reviews_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, pfeldman, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Consolidate manifest handler registration. BUG=229467 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198394

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : rename ManifestParser #

Patch Set 4 : clangit #

Patch Set 5 : android,chromeos + rebase #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -1282 lines) Patch
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_manifest_unittest.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/active_tab_unittest.cc View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service_new.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/file_handlers_api.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/file_handlers_api.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.h View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/page_launcher/page_launcher_api.h View 1 chunk +1 line, -21 lines 0 comments Download
M chrome/browser/extensions/api/page_launcher/page_launcher_api.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
D chrome/browser/extensions/api/plugins/plugins_api.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/extensions/api/plugins/plugins_api.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 4 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_api.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/extensions/api/system_indicator/system_indicator_api.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/extensions/chrome_manifest_parser.h View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/browser/extensions/chrome_manifest_parser.cc View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
D chrome/browser/extensions/content_scripts_parser.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/extensions/content_scripts_parser.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/extensions/convert_user_script_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 4 chunks +3 lines, -12 lines 0 comments Download
D chrome/browser/extensions/csp_parser.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/extensions/csp_parser.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_info_map_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 5 chunks +1 line, -8 lines 0 comments Download
A + chrome/browser/extensions/extension_web_ui_override_registrar.h View 1 2 3 chunks +13 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/extension_web_ui_override_registrar.cc View 1 2 2 chunks +9 lines, -27 lines 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/script_bubble_controller_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/extensions/web_accessible_resources_parser.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/extensions/web_accessible_resources_parser.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry_unittest.cc View 5 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 4 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 3 4 4 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller_unittest.mm View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 7 chunks +2 lines, -13 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 13 chunks +12 lines, -16 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
A chrome/common/extensions/chrome_manifest_handlers.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/common/extensions/chrome_manifest_handlers.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/common/extensions/extension_sync_type_unittest.cc View 1 chunk +3 lines, -10 lines 0 comments Download
D chrome/common/extensions/extension_unittest.h View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 18 chunks +16 lines, -44 lines 0 comments Download
M chrome/common/extensions/features/base_feature_provider_unittest.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_handler.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handler.cc View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/exclude_matches_manifest_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/shared_module_manifest_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission_set_unittest.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission_unittest.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 33 chunks +32 lines, -48 lines 0 comments Download
M chrome/common/extensions/permissions/socket_permission_unittest.cc View 6 chunks +6 lines, -9 lines 0 comments Download
M chrome/common/extensions/unpacker_unittest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +3 lines, -26 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Yoyo Zhou
Sorry this is so large, but it's mostly code deletion.
7 years, 7 months ago (2013-05-01 20:27:32 UTC) #1
Matt Perry
Nice! LGTM https://codereview.chromium.org/14694010/diff/1/chrome/common/extensions/chrome_manifest_handlers.h File chrome/common/extensions/chrome_manifest_handlers.h (right): https://codereview.chromium.org/14694010/diff/1/chrome/common/extensions/chrome_manifest_handlers.h#newcode10 chrome/common/extensions/chrome_manifest_handlers.h:10: // Registers all manifest handlers used in ...
7 years, 7 months ago (2013-05-01 20:39:08 UTC) #2
Yoyo Zhou
+sky for top-level files: chrome/browser/browser_process_impl.cc chrome/renderer/chrome_content_renderer_client.cc chrome/test/base/chrome_test_suite.cc chrome/utility/chrome_content_utility_client.cc +rdevlin.cronin FYI
7 years, 7 months ago (2013-05-01 21:13:40 UTC) #3
sky
LGTM
7 years, 7 months ago (2013-05-01 21:36:45 UTC) #4
Yoyo Zhou
I addressed my TODO to rename ChromeManifestParser (it's now ExtensionWebUIOverrideRegistrar).
7 years, 7 months ago (2013-05-01 22:32:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/14694010/7002
7 years, 7 months ago (2013-05-01 22:37:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/14694010/15001
7 years, 7 months ago (2013-05-01 23:04:21 UTC) #7
Yoyo Zhou
- fixed a ChromeOS test - removed some more extensions stuff (including tests) from the ...
7 years, 7 months ago (2013-05-02 21:15:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/14694010/33001
7 years, 7 months ago (2013-05-02 21:54:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110193
7 years, 7 months ago (2013-05-03 03:58:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/14694010/58001
7 years, 7 months ago (2013-05-03 13:20:52 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110566
7 years, 7 months ago (2013-05-03 16:20:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/14694010/58001
7 years, 7 months ago (2013-05-03 18:27:46 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 06:40:49 UTC) #14
Message was sent while issue was closed. 
Change committed as 198394

Powered by Google App Engine
This is Rietveld 408576698