chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 14694010: Consolidate manifest handler registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

index bb939037fce8cb6c3330918752aaa7f1f8592c1d..62c102383a549d8ee98769a3642709b531ed58c0 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

@@ -6,7 +6,6 @@

#include "base/json/json_file_value_serializer.h"

#include "base/memory/linked_ptr.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/extensions/background_info.h"

#include "chrome/common/extensions/csp_handler.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/incognito_handler.h"

@@ -19,14 +18,6 @@ namespace errors = extension_manifest_errors;

namespace extensions {

class PlatformAppsManifestTest : public ExtensionManifestTest {

- protected:

- virtual void SetUp() OVERRIDE {

- testing::Test::SetUp();

- (new BackgroundManifestHandler)->Register();

- (new CSPHandler(true))->Register(); // platform app.

- (new IncognitoHandler)->Register();

- (new AppIsolationHandler)->Register();

- }

};

TEST_F(PlatformAppsManifestTest, PlatformApps) {