Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension.h" 5 #include "chrome/common/extensions/extension.h"
6 #include "chrome/common/extensions/extension_manifest_constants.h" 6 #include "chrome/common/extensions/extension_manifest_constants.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "chrome/common/extensions/manifest_url_handler.h" 8 #include "chrome/common/extensions/manifest_url_handler.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 class DevToolsPageManifestTest : public ExtensionManifestTest { 11 class DevToolsPageManifestTest : public ExtensionManifestTest {
12 virtual void SetUp() OVERRIDE {
13 ExtensionManifestTest::SetUp();
14 (new extensions::DevToolsPageHandler)->Register();
15 }
16 }; 12 };
17 13
18 TEST_F(DevToolsPageManifestTest, DevToolsExtensions) { 14 TEST_F(DevToolsPageManifestTest, DevToolsExtensions) {
19 LoadAndExpectError("devtools_extension_url_invalid_type.json", 15 LoadAndExpectError("devtools_extension_url_invalid_type.json",
20 extension_manifest_errors::kInvalidDevToolsPage); 16 extension_manifest_errors::kInvalidDevToolsPage);
21 17
22 scoped_refptr<extensions::Extension> extension; 18 scoped_refptr<extensions::Extension> extension;
23 extension = LoadAndExpectSuccess("devtools_extension.json"); 19 extension = LoadAndExpectSuccess("devtools_extension.json");
24 EXPECT_EQ(extension->url().spec() + "devtools.html", 20 EXPECT_EQ(extension->url().spec() + "devtools.html",
25 extensions::ManifestURL::GetDevToolsPage(extension).spec()); 21 extensions::ManifestURL::GetDevToolsPage(extension).spec());
26 EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts()); 22 EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts());
27 } 23 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698