Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/file_manager_manifest_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_number_conversions.h" 5 #include "base/strings/string_number_conversions.h"
6 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handler.h " 6 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handler.h "
7 #include "chrome/common/extensions/extension_builder.h" 7 #include "chrome/common/extensions/extension_builder.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
10 #include "chrome/common/extensions/manifest_url_handler.h"
11 #include "chrome/common/extensions/value_builder.h" 10 #include "chrome/common/extensions/value_builder.h"
12 #include "extensions/common/error_utils.h" 11 #include "extensions/common/error_utils.h"
13 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
14 13
15 namespace errors = extension_manifest_errors; 14 namespace errors = extension_manifest_errors;
16 15
17 using extensions::DictionaryBuilder; 16 using extensions::DictionaryBuilder;
18 using extensions::Extension; 17 using extensions::Extension;
19 using extensions::ExtensionBuilder; 18 using extensions::ExtensionBuilder;
20 using extensions::ListBuilder; 19 using extensions::ListBuilder;
21 20
22 namespace { 21 namespace {
23 22
24 class FileBrowserHandlerManifestTest : public ExtensionManifestTest { 23 class FileBrowserHandlerManifestTest : public ExtensionManifestTest {
24 protected:
25 virtual void SetUp() OVERRIDE { 25 virtual void SetUp() OVERRIDE {
26 ExtensionManifestTest::SetUp(); 26 ExtensionManifestTest::SetUp();
27 (new FileBrowserHandlerParser)->Register(); 27 (new FileBrowserHandlerParser)->Register();
28 (new extensions::URLOverridesHandler)->Register();
29 } 28 }
30 }; 29 };
31 30
32 TEST_F(FileBrowserHandlerManifestTest, InvalidFileBrowserHandlers) { 31 TEST_F(FileBrowserHandlerManifestTest, InvalidFileBrowserHandlers) {
33 Testcase testcases[] = { 32 Testcase testcases[] = {
34 Testcase("filebrowser_invalid_access_permission.json", 33 Testcase("filebrowser_invalid_access_permission.json",
35 extensions::ErrorUtils::FormatErrorMessage( 34 extensions::ErrorUtils::FormatErrorMessage(
36 errors::kInvalidFileAccessValue, base::IntToString(1))), 35 errors::kInvalidFileAccessValue, base::IntToString(1))),
37 Testcase("filebrowser_invalid_access_permission_list.json", 36 Testcase("filebrowser_invalid_access_permission_list.json",
38 errors::kInvalidFileAccessList), 37 errors::kInvalidFileAccessList),
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 LoadExtension(Manifest(manifest_value.get(), "override_files"), 173 LoadExtension(Manifest(manifest_value.get(), "override_files"),
175 &error, extensions::Manifest::COMPONENT, Extension::NO_FLAGS); 174 &error, extensions::Manifest::COMPONENT, Extension::NO_FLAGS);
176 #if defined(FILE_MANAGER_EXTENSION) 175 #if defined(FILE_MANAGER_EXTENSION)
177 EXPECT_EQ("", error); 176 EXPECT_EQ("", error);
178 #else 177 #else
179 EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error); 178 EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error);
180 #endif 179 #endif
181 } 180 }
182 181
183 } // namespace 182 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/extensions/active_tab_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698