Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension.h" 5 #include "chrome/common/extensions/extension.h"
6 #include "chrome/common/extensions/extension_manifest_constants.h" 6 #include "chrome/common/extensions/extension_manifest_constants.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "chrome/common/extensions/manifest_url_handler.h" 8 #include "chrome/common/extensions/manifest_url_handler.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
11 11
12 namespace errors = extension_manifest_errors; 12 namespace errors = extension_manifest_errors;
13 13
14 class HomepageURLManifestTest : public ExtensionManifestTest { 14 class HomepageURLManifestTest : public ExtensionManifestTest {
15 virtual void SetUp() OVERRIDE {
16 ExtensionManifestTest::SetUp();
17 (new extensions::HomepageURLHandler)->Register();
18 (new extensions::UpdateURLHandler)->Register();
19 }
20 }; 15 };
21 16
22 TEST_F(HomepageURLManifestTest, ParseHomepageURLs) { 17 TEST_F(HomepageURLManifestTest, ParseHomepageURLs) {
23 scoped_refptr<extensions::Extension> extension( 18 scoped_refptr<extensions::Extension> extension(
24 LoadAndExpectSuccess("homepage_valid.json")); 19 LoadAndExpectSuccess("homepage_valid.json"));
25 20
26 Testcase testcases[] = { 21 Testcase testcases[] = {
27 Testcase("homepage_empty.json", 22 Testcase("homepage_empty.json",
28 errors::kInvalidHomepageURL), 23 errors::kInvalidHomepageURL),
29 Testcase("homepage_invalid.json", 24 Testcase("homepage_invalid.json",
(...skipping 14 matching lines...) Expand all
44 // The Google Gallery URL ends with the id, which depends on the path, which 39 // The Google Gallery URL ends with the id, which depends on the path, which
45 // can be different in testing, so we just check the part before id. 40 // can be different in testing, so we just check the part before id.
46 extension = LoadAndExpectSuccess("homepage_google_hosted.json"); 41 extension = LoadAndExpectSuccess("homepage_google_hosted.json");
47 EXPECT_TRUE(StartsWithASCII( 42 EXPECT_TRUE(StartsWithASCII(
48 extensions::ManifestURL::GetHomepageURL(extension).spec(), 43 extensions::ManifestURL::GetHomepageURL(extension).spec(),
49 "https://chrome.google.com/webstore/detail/", false)); 44 "https://chrome.google.com/webstore/detail/", false));
50 45
51 extension = LoadAndExpectSuccess("homepage_externally_hosted.json"); 46 extension = LoadAndExpectSuccess("homepage_externally_hosted.json");
52 EXPECT_EQ(GURL(), extensions::ManifestURL::GetHomepageURL(extension)); 47 EXPECT_EQ(GURL(), extensions::ManifestURL::GetHomepageURL(extension));
53 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698