Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7935)

Unified Diff: chrome/common/extensions/api/commands/commands_manifest_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/commands/commands_manifest_unittest.cc
diff --git a/chrome/common/extensions/api/commands/commands_manifest_unittest.cc b/chrome/common/extensions/api/commands/commands_manifest_unittest.cc
index c642ebccf3c0f42bb9e48939fb70f3fcb9a0d91c..02d34894169277e6a3df9a227af14dabe3180da9 100644
--- a/chrome/common/extensions/api/commands/commands_manifest_unittest.cc
+++ b/chrome/common/extensions/api/commands/commands_manifest_unittest.cc
@@ -8,7 +8,6 @@
#include "base/string_util.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/api/commands/commands_handler.h"
-#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace errors = extension_manifest_errors;
@@ -16,10 +15,6 @@ namespace errors = extension_manifest_errors;
namespace extensions {
class CommandsManifestTest : public ExtensionManifestTest {
- protected:
- virtual void SetUp() OVERRIDE {
- (new CommandsHandler)->Register();
- }
};
TEST_F(CommandsManifestTest, CommandManifestSimple) {
@@ -86,7 +81,6 @@ TEST_F(CommandsManifestTest, CommandManifestRejectJustShift) {
}
TEST_F(CommandsManifestTest, BrowserActionSynthesizesCommand) {
- (new BrowserActionHandler)->Register();
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("browser_action_synthesizes_command.json");
// An extension with a browser action but no extension command specified
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698