chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc - Issue 14694010: Consolidate manifest handler registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/page_launcher/page_launcher_api.cc ('k') | chrome/browser/extensions/api/plugins/plugins_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

index 2cfc545893e6eb290947b85d17a6e863205009ad..28c94acdde3e1fc200fa0347bfe0be4660b52a88 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

@@ -6,7 +6,6 @@

#include "base/values.h"

#include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h"

#include "chrome/common/extensions/api/permissions.h"

-#include "chrome/common/extensions/extension_unittest.h"

#include "chrome/common/extensions/permissions/permission_set.h"

#include "extensions/common/url_pattern_set.h"

#include "googleurl/src/gurl.h"

@@ -27,11 +26,8 @@ static void AddPattern(URLPatternSet* extent, const std::string& pattern) {

} // namespace

-class ExtensionPermissionsAPIHelpers : public ExtensionTest {

-};

// Tests that we can convert PermissionSets to and from values.

-TEST_F(ExtensionPermissionsAPIHelpers, Pack) {

+TEST(ExtensionPermissionsAPIHelpers, Pack) {

APIPermissionSet apis;

apis.insert(APIPermission::kTab);

apis.insert(APIPermission::kWebRequest);

@@ -80,7 +76,7 @@ TEST_F(ExtensionPermissionsAPIHelpers, Pack) {

// Tests various error conditions and edge cases when unpacking values

// into PermissionSets.

-TEST_F(ExtensionPermissionsAPIHelpers, Unpack) {

+TEST(ExtensionPermissionsAPIHelpers, Unpack) {

scoped_ptr<ListValue> apis(new ListValue());

apis->Append(Value::CreateStringValue("tabs"));

scoped_ptr<ListValue> origins(new ListValue());