Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1459323004: Revert of Initial version of external_oes texture support and unit test (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@target
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Initial version of external_oes texture support and unit test (patchset #14 id:260001 of https://codereview.chromium.org/1451683002/ ) Reason for revert: Error wrapping external texture in GrTexture on some devices. Original issue's description: > Initial version of external_oes texture support and unit test > > Committed: https://skia.googlesource.com/skia/+/27a048700778d4cebfc23301d1780649791b0e03 TBR=joshualitt@google.com,egdaniel@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0315dbcb554fe7f5fa80a81079fd8d2e61fc20e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -624 lines) Patch
M include/gpu/GrTypesPriv.h View 4 chunks +4 lines, -7 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/gl/SkGLContext.h View 3 chunks +1 line, -18 lines 0 comments Download
M include/gpu/gl/angle/SkANGLEGLContext.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +1 line, -20 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +3 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 15 chunks +110 lines, -178 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 2 chunks +9 lines, -24 lines 0 comments Download
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 5 chunks +4 lines, -62 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M src/gpu/gl/egl/GrGLCreateNativeInterface_egl.cpp View 1 chunk +1 line, -9 lines 0 comments Download
M src/gpu/gl/egl/SkCreatePlatformGLContext_egl.cpp View 3 chunks +0 lines, -59 lines 0 comments Download
M src/gpu/glsl/GrGLSL.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
D tests/EGLImageTest.cpp View 1 chunk +0 lines, -163 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Initial version of external_oes texture support and unit test
5 years, 1 month ago (2015-11-21 04:24:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459323004/1
5 years, 1 month ago (2015-11-21 04:24:21 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 04:24:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0315dbcb554fe7f5fa80a81079fd8d2e61fc20e1

Powered by Google App Engine
This is Rietveld 408576698