Add LSL (register, immediate) to ARM integrated assembler.

Add LSL (register, immediate) to ARM integrated assembler.

Also does some clean up on emitType01 methods (making optional argument
explicit, and moving rule checks to the lowest level).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f4d0a7a5819541ecb44ec7dafe151114981cdb88

[Karl, 2015-11-18 18:30:31]

Description was changed from

==========
Add LSL (register, immediate) to ARM integrated assembler.

Also does some clean up on emitType01 methods (making optional argument
explicit, and moving rule checks to the lowest level).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add LSL (register, immediate) to ARM integrated assembler.

Also does some clean up on emitType01 methods (making optional argument
explicit, and moving rule checks to the lowest level).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-11-18 18:30:31]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[John, 2015-11-19 14:18:40]

lgtm

[Karl, 2015-11-19 16:10:49]

Committed patchset #3 (id:40001) manually as
f4d0a7a5819541ecb44ec7dafe151114981cdb88 (presubmit successful).

[Jim Stichnoth, 2015-11-22 03:58:48]

otherwise necro lgtm

https://codereview.chromium.org/1456783003/diff/40001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1456783003/diff/40001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:452: if (((Rd == RegARM32::Encoded_Reg_pc) &&
SetFlags))
Maybe strip one level of parens?

https://codereview.chromium.org/1456783003/diff/40001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/lsl.ll (right):

https://codereview.chromium.org/1456783003/diff/40001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/lsl.ll:23: define internal i32 @_Z8testUdivhh(i32 %a,
i32 %b) {
What a lovely function name! :)  Of course it is actually the mangling of
"testUdiv(unsigned char, unsigned char)".  Maybe the unmangled names could be
used instead for the lit tests?

I'm actually puzzled as to how shifting gets involved in udiv, but I'm sure
there's a good explanation.  Even so, surely there could be a more direct
example than udiv?

[Karl, 2015-11-30 16:53:52]

Fixed in CL https://codereview.chromium.org/1484023002.

https://codereview.chromium.org/1456783003/diff/40001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1456783003/diff/40001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:452: if (((Rd == RegARM32::Encoded_Reg_pc) &&
SetFlags))
On 2015/11/22 03:58:47, stichnot wrote:
> Maybe strip one level of parens?

Done.

https://codereview.chromium.org/1456783003/diff/40001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/lsl.ll (right):

https://codereview.chromium.org/1456783003/diff/40001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/lsl.ll:23: define internal i32 @_Z8testUdivhh(i32 %a,
i32 %b) {
On 2015/11/22 03:58:47, stichnot wrote:
> What a lovely function name! :)  Of course it is actually the mangling of
> "testUdiv(unsigned char, unsigned char)".  Maybe the unmangled names could be
> used instead for the lit tests?
> 
> I'm actually puzzled as to how shifting gets involved in udiv, but I'm sure
> there's a good explanation.  Even so, surely there could be a more direct
> example than udiv?

Simplified.