Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1484023002: Fix nits from previous CLs. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -55 lines) Patch
M src/IceAssemblerARM32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceAssemblerARM32.cpp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M tests_lit/assembler/arm32/blx.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/assembler/arm32/lsl.ll View 1 chunk +21 lines, -41 lines 0 comments Download
M tests_lit/assembler/arm32/mvn.ll View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
5 years ago (2015-11-30 16:56:57 UTC) #3
Jim Stichnoth
lgtm
5 years ago (2015-11-30 18:27:58 UTC) #4
Karl
5 years ago (2015-11-30 19:19:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
515e8c22c1f74c64850e66087c7187b2969cf7d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698