[#7] Pass gfx structs by const ref (gfx::Size)

[#7] Pass gfx::Size by const ref.

Any struct of size > 4 bytes should be passed by const ref. 
Passing by ref for these structs is faster than passing by value,
especially when invoking function has multiple parameters and some
other scenarios mentioned in the bug.

BUG=159273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247769

[prashant.n, 2014-01-24 14:54:14]

PTAL.

[danakj, 2014-01-24 16:20:51]

Some compile issues to sort out still

[prashant.n, 2014-01-27 08:50:13]

+ bulach@ for

content/browser/android/in_process/synchronous_compositor_output_surface.h. &
.cc

+ piman@ for
content/browser/compositor/browser_compositor_output_surface.h & .cc
content/browser/compositor/software_output_device_win.h & .cc
content/renderer/gpu/compositor_software_output_device.h & .cc
content/renderer/gpu/mailbox_output_surface.h & .cc

[danakj, 2014-01-27 18:07:56]

LGTM

[piman, 2014-01-27 18:57:04]

lgtm

[commit-bot: I haz the power, 2014-01-28 04:01:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prashant.n@samsung.com/145313006/410001

[commit-bot: I haz the power, 2014-01-28 06:37:20]

Change committed as 247426

[Adam Rice, 2014-01-28 08:34:55]

A revert of this CL has been created in
https://codereview.chromium.org/142863008/ by ricea@chromium.org.

The reason for reverting is: Suspected of breaking the Linux ASAN tests (
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%...
).

[Adam Rice, 2014-01-28 09:41:30]

https://codereview.chromium.org/145313006/diff/410001/cc/resources/video_reso...
File cc/resources/video_resource_updater.h (right):

https://codereview.chromium.org/145313006/diff/410001/cc/resources/video_reso...
cc/resources/video_resource_updater.h:101: const gfx::Size& resource_size;
This object gets stored inside a base::Callback. When Run is called, the
resource_size reference will be invalid.

[r.kasibhatla, 2014-01-28 09:54:58]

https://codereview.chromium.org/145313006/diff/410001/cc/resources/video_reso...
File cc/resources/video_resource_updater.h (right):

https://codereview.chromium.org/145313006/diff/410001/cc/resources/video_reso...
cc/resources/video_resource_updater.h:101: const gfx::Size& resource_size;
On 2014/01/28 09:41:31, Adam Rice wrote:
> This object gets stored inside a base::Callback. When Run is called, the
> resource_size reference will be invalid.

Aah. Missed one in review. Sorry about that.

[prashant.n, 2014-01-28 10:33:39]

Fixed build break found by Adam. Thanks Adam.

https://codereview.chromium.org/145313006/diff/410001/cc/resources/video_reso...
File cc/resources/video_resource_updater.h (right):

https://codereview.chromium.org/145313006/diff/410001/cc/resources/video_reso...
cc/resources/video_resource_updater.h:101: const gfx::Size& resource_size;
On 2014/01/28 09:41:31, Adam Rice wrote:
> This object gets stored inside a base::Callback. When Run is called, the
> resource_size reference will be invalid.

Oops. Sorry for the change. Will put new patch.

[prashant.n, 2014-01-28 15:05:36]

Please review CL https://codereview.chromium.org/147603006/ as current CL is
reverted due to build break.

[prashant.n, 2014-01-29 11:12:07]

PTAL
Patch 3 is for fixing build error Adam pointed out.
Patch 4 is for rebase to TOT.

[danakj, 2014-01-29 18:35:30]

LGTM, thanks.

[commit-bot: I haz the power, 2014-01-29 18:35:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prashant.n@samsung.com/145313006/550001

[commit-bot: I haz the power, 2014-01-29 19:08:03]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 19:12:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prashant.n@samsung.com/145313006/550001

[commit-bot: I haz the power, 2014-01-29 22:58:46]

Change committed as 247769

[eddiejwilliams2014, 2014-04-24 04:22:52]

A revert of this CL has been created in
https://codereview.chromium.org/255553003/ by eddiejwilliams2014@gmail.com.

The reason for reverting is: K.