Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: cc/scheduler/texture_uploader.cc

Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/texture_uploader.h ('k') | cc/scheduler/texture_uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/texture_uploader.cc
diff --git a/cc/scheduler/texture_uploader.cc b/cc/scheduler/texture_uploader.cc
index e194ede6b74edfac19373e59a06bb043e2372ef1..b15fe41fa55569c00e3ac3132608927df8ac6347 100644
--- a/cc/scheduler/texture_uploader.cc
+++ b/cc/scheduler/texture_uploader.cc
@@ -133,7 +133,7 @@ void TextureUploader::Upload(const uint8* image,
const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format,
- gfx::Size size) {
+ const gfx::Size& size) {
CHECK(image_rect.Contains(source_rect));
bool is_full_upload = dest_offset.IsZero() && source_rect.size() == size;
@@ -287,7 +287,7 @@ void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
}
void TextureUploader::UploadWithTexImageETC1(const uint8* image,
- gfx::Size size) {
+ const gfx::Size& size) {
TRACE_EVENT0("cc", "TextureUploader::UploadWithTexImageETC1");
DCHECK_EQ(0, size.width() % 4);
DCHECK_EQ(0, size.height() % 4);
« no previous file with comments | « cc/scheduler/texture_uploader.h ('k') | cc/scheduler/texture_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698