cc/base/math_util.h - Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/math_util.h

Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/base/math_util.h

diff --git a/cc/base/math_util.h b/cc/base/math_util.h

index 6cad1ad1c5a4022bcb6ecb9957adef4fecc93225..fca08ef656e1e06c8e201294589cbb46a926a177 100644

--- a/cc/base/math_util.h

+++ b/cc/base/math_util.h

@@ -165,7 +165,7 @@ class CC_EXPORT MathUtil {

const gfx::Vector2dF& destination);

// Conversion to value.

- static scoped_ptr<base::Value> AsValue(gfx::Size s);

+ static scoped_ptr<base::Value> AsValue(const gfx::Size& s);

static scoped_ptr<base::Value> AsValue(const gfx::SizeF& s);

static scoped_ptr<base::Value> AsValue(const gfx::Rect& r);

static bool FromValue(const base::Value*, gfx::Rect* out_rect);

« no previous file with comments | « no previous file | cc/base/math_util.cc » ('j') | no next file with comments »