Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Unified Diff: cc/resources/resource_provider.cc

Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/resource_provider.h ('k') | cc/resources/resource_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/resource_provider.cc
diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc
index b43164847a0ad7ac62db9c801c499cd1448d7745..8b9453fc1b55bbd9145f8cdf6ccec734e72b30fb 100644
--- a/cc/resources/resource_provider.cc
+++ b/cc/resources/resource_provider.cc
@@ -197,7 +197,7 @@ ResourceProvider::Resource::Resource()
ResourceProvider::Resource::~Resource() {}
ResourceProvider::Resource::Resource(GLuint texture_id,
- gfx::Size size,
+ const gfx::Size& size,
GLenum target,
GLenum filter,
GLenum texture_pool,
@@ -240,7 +240,7 @@ ResourceProvider::Resource::Resource(GLuint texture_id,
ResourceProvider::Resource::Resource(uint8_t* pixels,
SharedBitmap* bitmap,
- gfx::Size size,
+ const gfx::Size& size,
GLenum filter,
GLint wrap_mode)
: child_id(0),
@@ -330,7 +330,7 @@ bool ResourceProvider::IsLost(ResourceId id) {
}
ResourceProvider::ResourceId ResourceProvider::CreateResource(
- gfx::Size size,
+ const gfx::Size& size,
GLint wrap_mode,
TextureUsageHint hint,
ResourceFormat format) {
@@ -355,7 +355,7 @@ ResourceProvider::ResourceId ResourceProvider::CreateResource(
}
ResourceProvider::ResourceId ResourceProvider::CreateManagedResource(
- gfx::Size size,
+ const gfx::Size& size,
GLenum target,
GLint wrap_mode,
TextureUsageHint hint,
@@ -381,7 +381,7 @@ ResourceProvider::ResourceId ResourceProvider::CreateManagedResource(
}
ResourceProvider::ResourceId ResourceProvider::CreateGLTexture(
- gfx::Size size,
+ const gfx::Size& size,
GLenum target,
GLenum texture_pool,
GLint wrap_mode,
@@ -400,7 +400,7 @@ ResourceProvider::ResourceId ResourceProvider::CreateGLTexture(
}
ResourceProvider::ResourceId ResourceProvider::CreateBitmap(
- gfx::Size size, GLint wrap_mode) {
+ const gfx::Size& size, GLint wrap_mode) {
DCHECK(thread_checker_.CalledOnValidThread());
scoped_ptr<SharedBitmap> bitmap;
« no previous file with comments | « cc/resources/resource_provider.h ('k') | cc/resources/resource_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698