Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 147603006: [#7] Resubmitted - Pass gfx structs by const ref (gfx::Size) (Closed)

Created:
6 years, 10 months ago by prashant.n
Modified:
6 years, 10 months ago
CC:
chromium-reviews, jbauman+watch_chromium.org, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, Berwal
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[#7] Resubmitted - Pass gfx::Size by const ref. (This patch is resubmitted as the earlier patch http://crrev.com/145313006 got reverted due to build break on linux_asan.) Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters and some other scenarios mentioned in the bug. BUG=159273

Patch Set 1 : Resubmit 145313006 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -308 lines) Patch
M cc/base/math_util.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/math_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/tiling_data.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/base/tiling_data.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/base/tiling_data_unittest.cc View 11 chunks +22 lines, -22 lines 0 comments Download
M cc/layers/delegated_renderer_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/heads_up_display_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/layer_position_constraint_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/tiled_layer_impl_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/ui_resource_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/copy_output_request.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/copy_output_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/copy_output_result.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/copy_output_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/direct_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/output/output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/shader.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/shader.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_output_device.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_output_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/content_draw_quad_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/content_draw_quad_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/io_surface_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/io_surface_draw_quad.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/picture_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/picture_draw_quad.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/shared_quad_state.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/shared_quad_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/tile_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/tile_draw_quad.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/bitmap_content_layer_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/bitmap_content_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/layer_tiling_data.h View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/layer_tiling_data.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/resources/layer_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.h View 4 chunks +7 lines, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling_set_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/picture_pile_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/picture_pile_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/prioritized_resource.h View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/prioritized_resource.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/resources/prioritized_resource_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/prioritized_resource_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/resource.h View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/resources/resource_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_pool.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/resource_provider.h View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/resource_provider.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M cc/resources/scoped_resource.h View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/resources/scoped_resource.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/shared_bitmap_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/skpicture_content_layer_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/skpicture_content_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/texture_mailbox.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/texture_mailbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/video_resource_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/texture_uploader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler/texture_uploader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler/texture_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/fake_picture_pile_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/test/layer_tree_pixel_test.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/pixel_test_output_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/pixel_test_software_output_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/pixel_test_software_output_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/skia_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/skia_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/test_texture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_texture.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.h View 5 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/occlusion_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/compositor_software_output_device.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/compositor_software_output_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/mailbox_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/mailbox_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
prashant.n
PTAL
6 years, 10 months ago (2014-01-28 15:07:00 UTC) #1
danakj
Can you either a) Upload the original patch here, then upload the changes so we ...
6 years, 10 months ago (2014-01-28 16:42:05 UTC) #2
prashant.n
6 years, 10 months ago (2014-01-29 11:19:57 UTC) #3
Please don't review this CL. I've modified original CL for the changes.

Powered by Google App Engine
This is Rietveld 408576698