[#7] Pass gfx structs by const ref (gfx::Size)

cc/resources/video_resource_updater.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_VIDEO_RESOURCE_UPDATER_H_
 #define CC_RESOURCES_VIDEO_RESOURCE_UPDATER_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 62 matching lines @@
       const scoped_refptr<media::VideoFrame>& video_frame);
 
  private:
   struct PlaneResource {
     unsigned resource_id;
     gfx::Size resource_size;
     ResourceFormat resource_format;
     gpu::Mailbox mailbox;
 
     PlaneResource(unsigned resource_id,
-                  gfx::Size resource_size,
+                  const gfx::Size& resource_size,
                   ResourceFormat resource_format,
                   gpu::Mailbox mailbox)
         : resource_id(resource_id),
           resource_size(resource_size),
           resource_format(resource_format),
           mailbox(mailbox) {}
   };
 
   void DeleteResource(unsigned resource_id);
   bool VerifyFrame(const scoped_refptr<media::VideoFrame>& video_frame);
   VideoFrameExternalResources CreateForHardwarePlanes(
       const scoped_refptr<media::VideoFrame>& video_frame);
   VideoFrameExternalResources CreateForSoftwarePlanes(
       const scoped_refptr<media::VideoFrame>& video_frame);
 
   struct RecycleResourceData {
     unsigned resource_id;
-    gfx::Size resource_size;
+    const gfx::Size& resource_size;

[Adam Rice, 2014/01/28 09:41:31]

This object gets stored inside a base::Callback. When Run is called, the
resource_size reference will be invalid.

[r.kasibhatla, 2014/01/28 09:55:00]

Aah. Missed one in review. Sorry about that.

[prashant.n, 2014/01/28 10:33:40]

Oops. Sorry for the change. Will put new patch.

     ResourceFormat resource_format;
     gpu::Mailbox mailbox;
   };
   static void RecycleResource(base::WeakPtr<VideoResourceUpdater> updater,
                               RecycleResourceData data,
                               unsigned sync_point,
                               bool lost_resource);
 
   ContextProvider* context_provider_;
   ResourceProvider* resource_provider_;
   scoped_ptr<media::SkCanvasVideoRenderer> video_renderer_;
 
   std::vector<unsigned> all_resources_;
   std::vector<PlaneResource> recycled_resources_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoResourceUpdater);
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_VIDEO_RESOURCE_UPDATER_H_