Revert of [#7] Pass gfx structs by const ref (gfx::Size)

Revert of [#7] Pass gfx structs by const ref (gfx::Size)  (https://codereview.chromium.org/145313006/)

Reason for revert:
Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 )

Original issue's description:
> [#7] Pass gfx::Size by const ref.
> 
> Any struct of size > 4 bytes should be passed by const ref. 
> Passing by ref for these structs is faster than passing by value,
> especially when invoking function has multiple parameters and some
> other scenarios mentioned in the bug.
> 
> BUG=159273
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426

TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=159273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247437

[Adam Rice, 2014-01-28 08:34:57]

Created Revert of [#7] Pass gfx structs by const ref (gfx::Size)

[r.kasibhatla, 2014-01-28 08:46:26]

I don't think this patch would cause asan errors. In this patch, there is no use
of heap variables at all. All it is doing is passing function parameters from
value to reference. As all function parameters are at stack level, the
heap-use-after-free case shouldn't arise from this patch.

[Adam Rice, 2014-01-28 09:44:40]

On 2014/01/28 08:46:26, r.kasibhatla wrote:
> I don't think this patch would cause asan errors. In this patch, there is no
use
> of heap variables at all. All it is doing is passing function parameters from
> value to reference. As all function parameters are at stack level, the
> heap-use-after-free case shouldn't arise from this patch.

A struct definition changed in video_resource_updater.h, changing one of the
struct members to a reference. See my comment on the original code review. I
haven't checked if there are any other struct definition changes in this CL.

[Adam Rice, 2014-01-28 10:30:43]

I am reverting via drover instead.

[Mattias Nissler (ping if slow), 2014-01-28 11:42:48]

Committed patchset #1 manually as r247437 (tree was closed).