Issue 1429073005: Add MLA instruction to ARM integerated assembler.

Issue 1429073005: Add MLA instruction to ARM integerated assembler. (Closed)

Created:
5 years, 1 month ago by Karl

Modified:
5 years, 1 month ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add MLA instruction to ARM integerated assembler. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=080b65b5e73b17d39d1f08b84af3c075b3e46e77

Patch Set 2 : Remove tabs. #

Total comments: 4

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -9 lines)			Patch
M	src/DartARM32/assembler_arm.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/DartARM32/assembler_arm.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/IceAssemblerARM32.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/IceAssemblerARM32.cpp	View		2 chunks	+32 lines, -4 lines	2 comments	Download
M	src/IceInstARM32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceInstARM32.cpp	View		2 chunks	+16 lines, -0 lines	2 comments	Download
M	src/IceTargetLoweringARM32.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests_lit/assembler/arm32/mul.ll	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1429073005/diff/20001/src/IceAssemblerARM32.cpp File src/IceAssemblerARM32.cpp (right): https://codereview.chromium.org/1429073005/diff/20001/src/IceAssemblerARM32.cpp#newcode913 src/IceAssemblerARM32.cpp:913: bool SetFlags = false; constexpr https://codereview.chromium.org/1429073005/diff/20001/src/IceInstARM32.cpp File src/IceInstARM32.cpp ...

5 years, 1 month ago (2015-11-05 00:15:05 UTC) #4

Karl

Committed patchset #2 (id:20001) manually as 080b65b5e73b17d39d1f08b84af3c075b3e46e77 (presubmit successful).

5 years, 1 month ago (2015-11-05 16:27:55 UTC) #5

Karl

5 years, 1 month ago (2015-11-05 16:28:20 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1429073005/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1429073005/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:913: bool SetFlags = false;
On 2015/11/05 00:15:04, stichnot wrote:
> constexpr

Done.

https://codereview.chromium.org/1429073005/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1429073005/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:202: ARM32::AssemblerARM32 *Asm =
Func->getAssembler<ARM32::AssemblerARM32>();
On 2015/11/05 00:15:04, stichnot wrote:
> auto *

Also fixed all other similar occurrences in this file.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages