Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass InterpolationEnvironment as a reference to InterpolationType conversion functions This change converts the InterpolationEnvironment* parameter of InterpolationType::maybeConvertPairwise() and InterpolationType::maybeConvertSingle() into an InterpolationEnvironment&. Previously we would attempt conversion of the keyframes without an environment until crrev.com/70ab3999 which removed the optimisation. This patch is to improve code health in the absence of this optimisation with the reasoning that we can add the optimisation back given performance data to justify the complexity cost. Committed: https://crrev.com/11fb42276c0ceff1f5e0ac9c3ff20b726692c8e0 Cr-Commit-Position: refs/heads/master@{#356769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -59 lines) Patch
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationType.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-10-27 02:45:21 UTC) #3
dstockwell
lgtm
5 years, 1 month ago (2015-10-27 06:59:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428513003/1
5 years, 1 month ago (2015-10-28 00:14:17 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/86814) mac_chromium_compile_dbg_ng on ...
5 years, 1 month ago (2015-10-28 00:18:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428513003/1
5 years, 1 month ago (2015-10-28 12:41:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/86984) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-10-28 12:44:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428513003/1
5 years, 1 month ago (2015-10-29 04:09:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 05:11:11 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 05:11:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11fb42276c0ceff1f5e0ac9c3ff20b726692c8e0
Cr-Commit-Position: refs/heads/master@{#356769}

Powered by Google App Engine
This is Rietveld 408576698