Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp

Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
index 25dda4ab6a5711170318d0dbf8573dea9567aae9..f8df2b8fcf4b3fa1c34cdd163a9e5545091169b2 100644
--- a/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
@@ -184,19 +184,19 @@ private:
RefPtrWillBePersistent<StyleImage> m_inheritedImage;
};
-PassOwnPtr<InterpolationValue> CSSImageInterpolationType::maybeConvertInherit(const StyleResolverState* state, ConversionCheckers& conversionCheckers) const
+PassOwnPtr<InterpolationValue> CSSImageInterpolationType::maybeConvertInherit(const StyleResolverState& state, ConversionCheckers& conversionCheckers) const
{
- if (!state || !state->parentStyle())
+ if (!state.parentStyle())
return nullptr;
- const StyleImage* inheritedImage = ImagePropertyFunctions::getStyleImage(cssProperty(), *state->parentStyle());
+ const StyleImage* inheritedImage = ImagePropertyFunctions::getStyleImage(cssProperty(), *state.parentStyle());
StyleImage* refableImage = const_cast<StyleImage*>(inheritedImage);
conversionCheckers.append(ParentImageChecker::create(*this, cssProperty(), refableImage));
InterpolationComponent component = maybeConvertStyleImage(inheritedImage, true);
return component ? InterpolationValue::create(*this, component) : nullptr;
}
-PassOwnPtr<InterpolationValue> CSSImageInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState*, ConversionCheckers&) const
+PassOwnPtr<InterpolationValue> CSSImageInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState&, ConversionCheckers&) const
{
InterpolationComponent component = maybeConvertCSSValue(value, true);
return component ? InterpolationValue::create(*this, component) : nullptr;

Powered by Google App Engine
This is Rietveld 408576698