third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp - Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

index 9f50bc2681bea9d4b506e024506df4f04430d3e9..785cb1c10969c37148f8965d278d01916fab28cd 100644

--- a/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

@@ -66,12 +66,12 @@ private:

const StyleColor m_color;

};

-PassOwnPtr<InterpolationValue> CSSPaintInterpolationType::maybeConvertInherit(const StyleResolverState* state, ConversionCheckers& conversionCheckers) const

+PassOwnPtr<InterpolationValue> CSSPaintInterpolationType::maybeConvertInherit(const StyleResolverState& state, ConversionCheckers& conversionCheckers) const

{

- if (!state || !state->parentStyle())

+ if (!state.parentStyle())

return nullptr;

StyleColor parentColor;

- if (!PaintPropertyFunctions::getColor(cssProperty(), *state->parentStyle(), parentColor)) {

+ if (!PaintPropertyFunctions::getColor(cssProperty(), *state.parentStyle(), parentColor)) {

conversionCheckers.append(ParentPaintChecker::create(*this, cssProperty()));

return nullptr;

}

@@ -79,7 +79,7 @@ PassOwnPtr<InterpolationValue> CSSPaintInterpolationType::maybeConvertInherit(co

return InterpolationValue::create(*this, CSSColorInterpolationType::createInterpolableColor(parentColor));

}

-PassOwnPtr<InterpolationValue> CSSPaintInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState*, ConversionCheckers&) const

+PassOwnPtr<InterpolationValue> CSSPaintInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState&, ConversionCheckers&) const

{

OwnPtr<InterpolableValue> interpolableColor = CSSColorInterpolationType::maybeCreateInterpolableColor(value);

if (!interpolableColor)