Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410993004: Make PropertyHandle::svgAttribute() return a reference (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell, Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_unCSSInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PropertyHandle::svgAttribute() return a reference Committed: https://crrev.com/f69199232df12593774d7fca0fbe525c35ed6ac9 Cr-Commit-Position: refs/heads/master@{#356732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/animation/PropertyHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1394343003 Patch 40001

Dependent Patchsets:

Issue 1414413002 Patch 1
Issue 1414413002 Patch 20001
Issue 1428513003 Patch 1

Messages

Total messages: 17 (7 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-21 00:14:36 UTC) #2
dstockwell
lgtm
5 years, 2 months ago (2015-10-21 03:52:03 UTC) #4
Timothy Loh
lgtm
5 years, 2 months ago (2015-10-21 03:52:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993004/1
5 years, 1 month ago (2015-10-28 00:14:12 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/86812) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-10-28 00:18:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993004/1
5 years, 1 month ago (2015-10-28 12:40:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/132428)
5 years, 1 month ago (2015-10-28 13:42:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993004/1
5 years, 1 month ago (2015-10-29 00:24:35 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 02:01:02 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 02:02:04 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f69199232df12593774d7fca0fbe525c35ed6ac9
Cr-Commit-Position: refs/heads/master@{#356732}

Powered by Google App Engine
This is Rietveld 408576698