third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp - Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp

Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp

index 152818047232099985787758d8a3429255e2cdcd..e116686be4667ed0d1ae48c931bcfc8fa270fb88 100644

--- a/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp

@@ -98,18 +98,18 @@ private:

StyleImageList m_inheritedImageList;

};

-PassOwnPtr<InterpolationValue> CSSImageListInterpolationType::maybeConvertInherit(const StyleResolverState* state, ConversionCheckers& conversionCheckers) const

+PassOwnPtr<InterpolationValue> CSSImageListInterpolationType::maybeConvertInherit(const StyleResolverState& state, ConversionCheckers& conversionCheckers) const

{

- if (!state || !state->parentStyle())

+ if (!state.parentStyle())

return nullptr;

StyleImageList inheritedImageList;

- ImageListPropertyFunctions::getImageList(cssProperty(), *state->parentStyle(), inheritedImageList);

+ ImageListPropertyFunctions::getImageList(cssProperty(), *state.parentStyle(), inheritedImageList);

conversionCheckers.append(ParentImageListChecker::create(*this, cssProperty(), inheritedImageList));

return maybeConvertStyleImageList(inheritedImageList);

}

-PassOwnPtr<InterpolationValue> CSSImageListInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState*, ConversionCheckers&) const

+PassOwnPtr<InterpolationValue> CSSImageListInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState&, ConversionCheckers&) const

{

if (value.isPrimitiveValue() && toCSSPrimitiveValue(value).getValueID() == CSSValueNone)

return nullptr;