Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1414413002: SVG Web Animations: Add SVGInterpolationType pipeline (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell, pdr., shans, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVG Web Animations: Add SVGInterpolationType pipeline This change starts the SVG family of InterpolationTypes with SVG specific interpolation environments. It adds SVGValueInterpolationType for the mode attribute as an initial implementation. SVG web animation composite modes are not yet introduced in this patch. BUG=530436 Committed: https://crrev.com/8baf66d6761c194409c707a66606974894b01b67 Cr-Commit-Position: refs/heads/master@{#356804}

Patch Set 1 #

Patch Set 2 : Add extra attributes #

Patch Set 3 : Change InterpolationEnvironment #

Total comments: 2

Patch Set 4 : TODO #

Patch Set 5 : TODO #

Patch Set 6 : baseValueBase #

Patch Set 7 : Move assert to not wrong location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -129 lines) Patch
M third_party/WebKit/Source/core/animation/InterpolationEnvironment.h View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGInterpolationType.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h View 1 2 2 chunks +16 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGValueInterpolationType.cpp View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SampledEffect.cpp View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 3 4 5 chunks +169 lines, -118 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStaticStringList.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-21 00:15:29 UTC) #2
dstockwell
lgtm https://codereview.chromium.org/1414413002/diff/40001/third_party/WebKit/Source/core/animation/StringKeyframe.cpp File third_party/WebKit/Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/1414413002/diff/40001/third_party/WebKit/Source/core/animation/StringKeyframe.cpp#newcode135 third_party/WebKit/Source/core/animation/StringKeyframe.cpp:135: const Vector<const InterpolationType*>* applicableTypesForProperty(PropertyHandle property) As discussed I ...
5 years, 1 month ago (2015-10-28 03:29:16 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1414413002/diff/40001/third_party/WebKit/Source/core/animation/StringKeyframe.cpp File third_party/WebKit/Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/1414413002/diff/40001/third_party/WebKit/Source/core/animation/StringKeyframe.cpp#newcode135 third_party/WebKit/Source/core/animation/StringKeyframe.cpp:135: const Vector<const InterpolationType*>* applicableTypesForProperty(PropertyHandle property) On 2015/10/28 at 03:29:16, ...
5 years, 1 month ago (2015-10-28 03:48:45 UTC) #4
alancutter (OOO until 2018)
Turns out there was a bug in this implementation where I was using currentValueBase() which ...
5 years, 1 month ago (2015-10-29 06:28:09 UTC) #6
fs
On 2015/10/29 at 06:28:09, alancutter wrote: > Turns out there was a bug in this ...
5 years, 1 month ago (2015-10-29 08:54:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414413002/100001
5 years, 1 month ago (2015-10-29 08:55:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414413002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414413002/120001
5 years, 1 month ago (2015-10-29 08:59:18 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 1 month ago (2015-10-29 10:27:58 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 10:28:49 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8baf66d6761c194409c707a66606974894b01b67
Cr-Commit-Position: refs/heads/master@{#356804}

Powered by Google App Engine
This is Rietveld 408576698