third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp - Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

Issue 1428513003: Pass InterpolationEnvironment as a reference to InterpolationType conversion functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

index dc4415d567f6b8f103dc559ca18d3252b51d57cf..0cb257cd01f7bf233a4274d3152ca393da39c876 100644

--- a/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

@@ -57,18 +57,18 @@ PassOwnPtr<InterpolationValue> CSSNumberInterpolationType::maybeConvertInitial()

return createNumberValue(initialNumber);

}

-PassOwnPtr<InterpolationValue> CSSNumberInterpolationType::maybeConvertInherit(const StyleResolverState* state, ConversionCheckers& conversionCheckers) const

+PassOwnPtr<InterpolationValue> CSSNumberInterpolationType::maybeConvertInherit(const StyleResolverState& state, ConversionCheckers& conversionCheckers) const

{

- if (!state || !state->parentStyle())

+ if (!state.parentStyle())

return nullptr;

double inheritedNumber;

- if (!NumberPropertyFunctions::getNumber(cssProperty(), *state->parentStyle(), inheritedNumber))

+ if (!NumberPropertyFunctions::getNumber(cssProperty(), *state.parentStyle(), inheritedNumber))

return nullptr;

conversionCheckers.append(ParentNumberChecker::create(*this, cssProperty(), inheritedNumber));

return createNumberValue(inheritedNumber);

}

-PassOwnPtr<InterpolationValue> CSSNumberInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState*, ConversionCheckers&) const

+PassOwnPtr<InterpolationValue> CSSNumberInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState&, ConversionCheckers&) const

{

if (!value.isPrimitiveValue() || !toCSSPrimitiveValue(value).isNumber())

return nullptr;