Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1426653008: Revert of Create swizzle table inside of glsl caps (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create swizzle table inside of glsl caps (patchset #12 id:210001 of https://codereview.chromium.org/1420033005/ ) Reason for revert: Breaking gm's on nexus7 and s3 Original issue's description: > Create swizzle table inside of glsl caps > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4036674952f341dab0695c3b054fefa5bb8cdec1 TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0c2999974d189ea257f82c9b7672d9afda52f6c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -166 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 6 chunks +12 lines, -40 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +17 lines, -30 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +19 lines, -6 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 3 chunks +38 lines, -46 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 3 chunks +0 lines, -14 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
M src/gpu/glsl/GrGLSLTextureSampler.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Create swizzle table inside of glsl caps
5 years, 1 month ago (2015-11-03 18:32:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426653008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426653008/1
5 years, 1 month ago (2015-11-03 18:33:10 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 18:33:17 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0c2999974d189ea257f82c9b7672d9afda52f6c2

Powered by Google App Engine
This is Rietveld 408576698