Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed)

Created:
5 years, 1 month ago by jbudorick
Modified:
5 years, 1 month ago
Reviewers:
Nico, jam, sky, vmpstr
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, posciak+watch_chromium.org, vabr+watchlist_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, tracing+reviews_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdanderson+views_chromium.org, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, tdresser+watch_chromium.org, csharrison+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, cc-bugs_chromium.org, mkwst+watchlist-passwords_chromium.org, feature-media-reviews_chromium.org, wfh+watch_chromium.org, mcasas+watch_chromium.org, loading-reviews+metrics_chromium.org, tfarina, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (patchset #3 id:40001 of https://codereview.chromium.org/1421483005/ ) Reason for revert: breaks compilation on multiple builders, including but not limited to: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/132580 http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/91670 Original issue's description: > Remove DCHECK_IMPLIES/CHECK_IMPLIES. > > This patch removes both DCHECK_IMPLIES and CHECK_IMPLIES macros. > > R=thakis, sky, jam > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/cc8936ba36ee29b5859f65c936e16f87eeac82b4 > Cr-Commit-Position: refs/heads/master@{#356193} TBR=thakis@chromium.org,sky@chromium.org,jam@chromium.org,vmpstr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/625f6c8cd6bda5cd7a5b1691376956bb8f300785 Cr-Commit-Position: refs/heads/master@{#356202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -134 lines) Patch
M base/logging.h View 2 chunks +2 lines, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/input/top_controls_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/display_item_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/texture_mailbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_display_list_raster_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiles/picture_layer_tiling.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/tracing/child_memory_dump_manager_delegate_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/discardable_shared_memory_heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/client/gl_helper_scaling.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/media/vp9_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/gpu/mailbox_output_surface.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M content/test/test_render_frame_host.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_fence_egl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_image_memory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.
5 years, 1 month ago (2015-10-27 00:52:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417903005/1
5 years, 1 month ago (2015-10-27 00:53:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 00:55:00 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:56:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/625f6c8cd6bda5cd7a5b1691376956bb8f300785
Cr-Commit-Position: refs/heads/master@{#356202}

Powered by Google App Engine
This is Rietveld 408576698