cc/output/direct_renderer.cc - Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/direct_renderer.cc

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/direct_renderer.cc

diff --git a/cc/output/direct_renderer.cc b/cc/output/direct_renderer.cc

index 0083427d3f50deacf362798dfc65984f435de233..1be41e9216244f7695506283ce4779778e768c79 100644

--- a/cc/output/direct_renderer.cc

+++ b/cc/output/direct_renderer.cc

@@ -436,8 +436,8 @@

// If |has_external_stencil_test| we can't discard or clear. Make sure we

// don't need to.

- DCHECK(!has_external_stencil_test ||

- !frame->current_render_pass->has_transparent_background);

+ DCHECK_IMPLIES(has_external_stencil_test,

+ !frame->current_render_pass->has_transparent_background);

SurfaceInitializationMode mode;

if (should_clear_surface && render_pass_is_clipped) {

« no previous file with comments | « cc/layers/video_layer_impl.cc ('k') | cc/output/gl_renderer.cc » ('j') | no next file with comments »