cc/tiles/picture_layer_tiling_set.cc - Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/picture_layer_tiling_set.cc

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/tiles/picture_layer_tiling_set.cc

diff --git a/cc/tiles/picture_layer_tiling_set.cc b/cc/tiles/picture_layer_tiling_set.cc

index 0848e61d79869613a2762ee8a7dd8cd97c858e23..9facf9f252c980da9c8f8d1cef8876c58dd79827 100644

--- a/cc/tiles/picture_layer_tiling_set.cc

+++ b/cc/tiles/picture_layer_tiling_set.cc

@@ -140,7 +140,7 @@

// Invalidate tiles and update them to the new raster source.

for (PictureLayerTiling* tiling : tilings_) {

- DCHECK(tree_ != PENDING_TREE || !tiling->has_tiles());

+ DCHECK_IMPLIES(tree_ == PENDING_TREE, !tiling->has_tiles());

tiling->SetRasterSourceAndResize(raster_source);

// We can commit on either active or pending trees, but only active one can

« no previous file with comments | « cc/tiles/picture_layer_tiling.cc ('k') | cc/tiles/tile_manager.cc » ('j') | no next file with comments »