content/browser/frame_host/render_frame_proxy_host.cc - Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_proxy_host.cc

diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc

index 8f9e57f50187cd96e7a499f24a92379afb16e9c4..2ef3d264d614746cf3d1e7566044741685922488 100644

--- a/content/browser/frame_host/render_frame_proxy_host.cc

+++ b/content/browser/frame_host/render_frame_proxy_host.cc

@@ -57,9 +57,9 @@

std::make_pair(

RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_),

this)).second);

- CHECK(render_view_host ||

- (frame_tree_node_->render_manager()->ForInnerDelegate() &&

- frame_tree_node_->IsMainFrame()));

+ CHECK_IMPLIES(!render_view_host,

+ frame_tree_node_->render_manager()->ForInnerDelegate() &&

+ frame_tree_node_->IsMainFrame());

if (render_view_host)

frame_tree_node_->frame_tree()->AddRenderViewHostRef(render_view_host_);