components/tracing/child_memory_dump_manager_delegate_impl.h - Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child_memory_dump_manager_delegate_impl.h

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/child_memory_dump_manager_delegate_impl.h

diff --git a/components/tracing/child_memory_dump_manager_delegate_impl.h b/components/tracing/child_memory_dump_manager_delegate_impl.h

index 8150a07f3335a1e7d616cf9d102290f27fdd3ccb..007776a81029f771cef794cb7bc83d10045c0542 100644

--- a/components/tracing/child_memory_dump_manager_delegate_impl.h

+++ b/components/tracing/child_memory_dump_manager_delegate_impl.h

@@ -41,11 +41,11 @@

// Pass kInvalidTracingProcessId to invalidate the id.

void set_tracing_process_id(uint64 id) {

- DCHECK(tracing_process_id_ ==

- base::trace_event::MemoryDumpManager::kInvalidTracingProcessId ||

- id ==

- base::trace_event::MemoryDumpManager::kInvalidTracingProcessId ||

- id == tracing_process_id_);

+ DCHECK_IMPLIES(

+ tracing_process_id_ !=

+ base::trace_event::MemoryDumpManager::kInvalidTracingProcessId,

+ id == base::trace_event::MemoryDumpManager::kInvalidTracingProcessId ||

+ id == tracing_process_id_);

tracing_process_id_ = id;

}