gpu/command_buffer/service/texture_definition.cc - Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_definition.cc

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/texture_definition.cc

diff --git a/gpu/command_buffer/service/texture_definition.cc b/gpu/command_buffer/service/texture_definition.cc

index 3f16e8503fa7f94ee6df56d892a18f9d06e4be59..ad9fe8a9a105bc17d20492acfa2756310a933a3f 100644

--- a/gpu/command_buffer/service/texture_definition.cc

+++ b/gpu/command_buffer/service/texture_definition.cc

@@ -334,7 +334,7 @@

usage_(texture->usage()),

immutable_(texture->IsImmutable()),

defined_(texture->IsDefined()) {

- DCHECK(!image_buffer_.get() || defined_);

+ DCHECK_IMPLIES(image_buffer_.get(), defined_);

if (!image_buffer_.get() && defined_) {

image_buffer_ = NativeImageBuffer::Create(texture->service_id());

DCHECK(image_buffer_.get());

« no previous file with comments | « gpu/command_buffer/service/mailbox_manager_sync.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »