components/page_load_metrics/browser/metrics_web_contents_observer.cc - Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | components/tracing/child_memory_dump_manager_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc

index 6fed6cafafe4b3b35f96129b35e328160a159ade..d19d332f7f623a008c39228f9d27bd154404c7b2 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc

@@ -49,8 +49,9 @@

DCHECK(!timing.navigation_start.is_null());

// If we have a DOM content loaded event, we should have a response start.

- DCHECK(timing.dom_content_loaded_event_start.is_zero() ||

- timing.response_start <= timing.dom_content_loaded_event_start);

+ DCHECK_IMPLIES(

+ !timing.dom_content_loaded_event_start.is_zero(),

+ timing.response_start <= timing.dom_content_loaded_event_start);

// If we have a load event, we should have both a response start and a DCL.

// TODO(csharrison) crbug.com/536203 shows that sometimes we can get a load