Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141273002: Code problems detected by cppcheck (Closed)

Created:
6 years, 11 months ago by rwlbuis
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, jamesr, krit, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, Timothy Loh, danakj, dstockwell, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, pdr., Eric Willigers, rjwright, zoltan1, sof, jbroman, darktears, Nate Chapin, leviw+renderwatch, Mike Lawther (Google), f(malita), Inactive, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Code problems detected by cppcheck Testing cppcheck with flags style and performance showed up these problems. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165481

Patch Set 1 #

Patch Set 2 : Add a few more fixes #

Total comments: 7

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -37 lines) Patch
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/BasicShapes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextQuery.cpp View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/DateComponents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Decimal.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebHTTPLoadInfo.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebString.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/network/HTTPRequest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/text/WTFString.h View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rwlbuis
A decent sized cleanup patch.
6 years, 11 months ago (2014-01-17 00:18:33 UTC) #1
Inactive
https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/BasicShapes.cpp File Source/core/rendering/style/BasicShapes.cpp (right): https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/BasicShapes.cpp#newcode216 Source/core/rendering/style/BasicShapes.cpp:216: return m_centerX == other.m_centerX && m_centerY == other.m_centerY && ...
6 years, 11 months ago (2014-01-17 00:54:52 UTC) #2
Inactive
lgtm for core/ https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/RenderStyle.cpp File Source/core/rendering/style/RenderStyle.cpp (left): https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/RenderStyle.cpp#oldcode500 Source/core/rendering/style/RenderStyle.cpp:500: || rareInheritedData->m_textAlignLast != other->rareInheritedData->m_textAlignLast On 2014/01/17 ...
6 years, 11 months ago (2014-01-17 00:56:10 UTC) #3
rwlbuis
https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/RenderStyle.cpp#oldcode500 > Source/core/rendering/style/RenderStyle.cpp:500: || > rareInheritedData->m_textAlignLast != other->rareInheritedData->m_textAlignLast > What's wrong with this one? Is ...
6 years, 11 months ago (2014-01-17 00:57:33 UTC) #4
rwlbuis
https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/RenderStyle.cpp#oldcode500 > Source/core/rendering/style/RenderStyle.cpp:500: || > rareInheritedData->m_textAlignLast != other->rareInheritedData->m_textAlignLast > What's wrong with this one? Is ...
6 years, 11 months ago (2014-01-17 00:57:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/141273002/40001
6 years, 11 months ago (2014-01-17 00:58:24 UTC) #6
Inactive
The rest looks good as well, non-owner lgtm for the rest.
6 years, 11 months ago (2014-01-17 00:59:00 UTC) #7
abarth-chromium
LGTM. Minor comments below https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/BasicShapes.cpp File Source/core/rendering/style/BasicShapes.cpp (right): https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/BasicShapes.cpp#newcode216 Source/core/rendering/style/BasicShapes.cpp:216: return m_centerX == other.m_centerX && ...
6 years, 11 months ago (2014-01-17 06:59:07 UTC) #8
rwlbuis
On 2014/01/17 06:59:07, abarth wrote: > https://codereview.chromium.org/141273002/diff/40001/Source/core/rendering/style/BasicShapes.cpp#newcode216 > Source/core/rendering/style/BasicShapes.cpp:216: return m_centerX == > other.m_centerX && ...
6 years, 11 months ago (2014-01-21 15:13:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/141273002/230001
6 years, 11 months ago (2014-01-21 15:14:21 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 21:11:59 UTC) #11
Message was sent while issue was closed. 
Change committed as 165481

Powered by Google App Engine
This is Rietveld 408576698