Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1938)

Side by Side Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add a few more fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 || rareInheritedData->textSecurity != other->rareInheritedData->text Security 490 || rareInheritedData->textSecurity != other->rareInheritedData->text Security
491 || rareInheritedData->hyphens != other->rareInheritedData->hyphens 491 || rareInheritedData->hyphens != other->rareInheritedData->hyphens
492 || rareInheritedData->hyphenationLimitBefore != other->rareInherited Data->hyphenationLimitBefore 492 || rareInheritedData->hyphenationLimitBefore != other->rareInherited Data->hyphenationLimitBefore
493 || rareInheritedData->hyphenationLimitAfter != other->rareInheritedD ata->hyphenationLimitAfter 493 || rareInheritedData->hyphenationLimitAfter != other->rareInheritedD ata->hyphenationLimitAfter
494 || rareInheritedData->hyphenationString != other->rareInheritedData- >hyphenationString 494 || rareInheritedData->hyphenationString != other->rareInheritedData- >hyphenationString
495 || rareInheritedData->locale != other->rareInheritedData->locale 495 || rareInheritedData->locale != other->rareInheritedData->locale
496 || rareInheritedData->m_rubyPosition != other->rareInheritedData->m_ rubyPosition 496 || rareInheritedData->m_rubyPosition != other->rareInheritedData->m_ rubyPosition
497 || rareInheritedData->textEmphasisMark != other->rareInheritedData-> textEmphasisMark 497 || rareInheritedData->textEmphasisMark != other->rareInheritedData-> textEmphasisMark
498 || rareInheritedData->textEmphasisPosition != other->rareInheritedDa ta->textEmphasisPosition 498 || rareInheritedData->textEmphasisPosition != other->rareInheritedDa ta->textEmphasisPosition
499 || rareInheritedData->textEmphasisCustomMark != other->rareInherited Data->textEmphasisCustomMark 499 || rareInheritedData->textEmphasisCustomMark != other->rareInherited Data->textEmphasisCustomMark
500 || rareInheritedData->m_textAlignLast != other->rareInheritedData->m _textAlignLast
Inactive 2014/01/17 00:54:53 What's wrong with this one?
Inactive 2014/01/17 00:56:11 Oh, it is duplicated. Nevermind.
501 || rareInheritedData->m_textJustify != other->rareInheritedData->m_t extJustify 500 || rareInheritedData->m_textJustify != other->rareInheritedData->m_t extJustify
502 || rareInheritedData->m_textOrientation != other->rareInheritedData- >m_textOrientation 501 || rareInheritedData->m_textOrientation != other->rareInheritedData- >m_textOrientation
503 || rareInheritedData->m_tabSize != other->rareInheritedData->m_tabSi ze 502 || rareInheritedData->m_tabSize != other->rareInheritedData->m_tabSi ze
504 || rareInheritedData->m_lineBoxContain != other->rareInheritedData-> m_lineBoxContain 503 || rareInheritedData->m_lineBoxContain != other->rareInheritedData-> m_lineBoxContain
505 || rareInheritedData->m_lineGrid != other->rareInheritedData->m_line Grid 504 || rareInheritedData->m_lineGrid != other->rareInheritedData->m_line Grid
506 || rareInheritedData->m_lineSnap != other->rareInheritedData->m_line Snap 505 || rareInheritedData->m_lineSnap != other->rareInheritedData->m_line Snap
507 || rareInheritedData->m_lineAlign != other->rareInheritedData->m_lin eAlign 506 || rareInheritedData->m_lineAlign != other->rareInheritedData->m_lin eAlign
508 || rareInheritedData->listStyleImage != other->rareInheritedData->li stStyleImage 507 || rareInheritedData->listStyleImage != other->rareInheritedData->li stStyleImage
509 || rareInheritedData->textStrokeWidth != other->rareInheritedData->t extStrokeWidth) 508 || rareInheritedData->textStrokeWidth != other->rareInheritedData->t extStrokeWidth)
510 return StyleDifferenceLayout; 509 return StyleDifferenceLayout;
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
1591 } 1590 }
1592 1591
1593 void RenderStyle::setBorderImageOutset(const BorderImageLengthBox& outset) 1592 void RenderStyle::setBorderImageOutset(const BorderImageLengthBox& outset)
1594 { 1593 {
1595 if (surround->border.m_image.outset() == outset) 1594 if (surround->border.m_image.outset() == outset)
1596 return; 1595 return;
1597 surround.access()->border.m_image.setOutset(outset); 1596 surround.access()->border.m_image.setOutset(outset);
1598 } 1597 }
1599 1598
1600 } // namespace WebCore 1599 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698