Source/platform/exported/WebString.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/exported/WebString.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/exported/WebString.cpp

diff --git a/Source/platform/exported/WebString.cpp b/Source/platform/exported/WebString.cpp

index 789e95d1e588daeadcbd5486ae9c240e0d6ecabd..1dafd9fad2efd1e4677e0786b94c5b9c1e0ec369 100644

--- a/Source/platform/exported/WebString.cpp

+++ b/Source/platform/exported/WebString.cpp

@@ -121,8 +121,8 @@ bool WebString::equals(const WebString& s) const

}

WebString::WebString(const WTF::String& s)

+ : m_private(s.impl())

{

- m_private = s.impl();

}

WebString& WebString::operator=(const WTF::String& s)