Source/platform/Decimal.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/Decimal.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/Decimal.cpp

diff --git a/Source/platform/Decimal.cpp b/Source/platform/Decimal.cpp

index b8c093e3f4e130ea2b5b717d8a5f6b3a9884484c..5ee960b6179d420649f8ff9c7bb02ada6c6798b8 100644

--- a/Source/platform/Decimal.cpp

+++ b/Source/platform/Decimal.cpp

@@ -140,7 +140,6 @@ public:

private:

static uint32_t highUInt32(uint64_t x) { return static_cast<uint32_t>(x >> 32); }

static uint32_t lowUInt32(uint64_t x) { return static_cast<uint32_t>(x & ((static_cast<uint64_t>(1) << 32) - 1)); }

- bool isZero() const { return !m_low && !m_high; }

static uint64_t makeUInt64(uint32_t low, uint32_t high) { return low | (static_cast<uint64_t>(high) << 32); }

static uint64_t multiplyHigh(uint64_t, uint64_t);

« no previous file with comments | « Source/platform/DateComponents.cpp ('k') | Source/platform/exported/WebHTTPLoadInfo.cpp » ('j') | no next file with comments »