Source/core/rendering/svg/RenderSVGShape.h - Issue 141273002: Code problems detected by cppcheck

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/svg/RenderSVGShape.h

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/rendering/style/RenderStyle.cpp ('k') | Source/core/rendering/svg/SVGTextQuery.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>

4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>	4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>

5 * Copyright (C) 2006 Apple Computer, Inc	5 * Copyright (C) 2006 Apple Computer, Inc

6 * Copyright (C) 2009 Google, Inc.	6 * Copyright (C) 2009 Google, Inc.

7 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>	7 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>

8 * Copyright (C) 2011 University of Szeged	8 * Copyright (C) 2011 University of Szeged

9 *	9 *

10 * This library is free software; you can redistribute it and/or	10 * This library is free software; you can redistribute it and/or

(...skipping 97 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 bool shouldGenerateMarkerPositions() const;	108 bool shouldGenerateMarkerPositions() const;

109 FloatRect markerRect(float strokeWidth) const;	109 FloatRect markerRect(float strokeWidth) const;

110 void processMarkerPositions();	110 void processMarkerPositions();

111	111

112 void fillShape(RenderStyle, GraphicsContext);	112 void fillShape(RenderStyle, GraphicsContext);

113 void strokeShape(RenderStyle, GraphicsContext);	113 void strokeShape(RenderStyle, GraphicsContext);

114 void drawMarkers(PaintInfo&);	114 void drawMarkers(PaintInfo&);

115	115

116 private:	116 private:

117 FloatRect m_repaintBoundingBox;	117 FloatRect m_repaintBoundingBox;

118 FloatRect m_repaintBoundingBoxExcludingShadow;

119 AffineTransform m_localTransform;	118 AffineTransform m_localTransform;

120 OwnPtr<Path> m_path;	119 OwnPtr<Path> m_path;

121 Vector<MarkerPosition> m_markerPositions;	120 Vector<MarkerPosition> m_markerPositions;

122	121

123 bool m_needsBoundariesUpdate : 1;	122 bool m_needsBoundariesUpdate : 1;

124 bool m_needsShapeUpdate : 1;	123 bool m_needsShapeUpdate : 1;

125 bool m_needsTransformUpdate : 1;	124 bool m_needsTransformUpdate : 1;

126 };	125 };

127	126

128 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGShape, isSVGShape());	127 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGShape, isSVGShape());

129	128

130 }	129 }

131	130

132 #endif	131 #endif

OLD	NEW