Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: Source/core/xml/XPathFunctions.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGAnimateMotionElement.cpp ('k') | Source/platform/DateComponents.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005 Frerich Raabe <raabe@kde.org> 2 * Copyright (C) 2005 Frerich Raabe <raabe@kde.org>
3 * Copyright (C) 2006, 2009 Apple Inc. 3 * Copyright (C) 2006, 2009 Apple Inc.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 293
294 void Function::setArguments(Vector<OwnPtr<Expression> >& args) 294 void Function::setArguments(Vector<OwnPtr<Expression> >& args)
295 { 295 {
296 ASSERT(!subExprCount()); 296 ASSERT(!subExprCount());
297 297
298 // Some functions use context node as implicit argument, so when explicit ar guments are added, they may no longer be context node sensitive. 298 // Some functions use context node as implicit argument, so when explicit ar guments are added, they may no longer be context node sensitive.
299 if (m_name != "lang" && !args.isEmpty()) 299 if (m_name != "lang" && !args.isEmpty())
300 setIsContextNodeSensitive(false); 300 setIsContextNodeSensitive(false);
301 301
302 Vector<OwnPtr<Expression> >::iterator end = args.end(); 302 Vector<OwnPtr<Expression> >::iterator end = args.end();
303 for (Vector<OwnPtr<Expression> >::iterator it = args.begin(); it != end; it+ +) 303 for (Vector<OwnPtr<Expression> >::iterator it = args.begin(); it != end; ++i t)
304 addSubExpression(it->release()); 304 addSubExpression(it->release());
305 } 305 }
306 306
307 Value FunLast::evaluate() const 307 Value FunLast::evaluate() const
308 { 308 {
309 return Expression::evaluationContext().size; 309 return Expression::evaluationContext().size;
310 } 310 }
311 311
312 Value FunPosition::evaluate() const 312 Value FunPosition::evaluate() const
313 { 313 {
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 return 0; 744 return 0;
745 745
746 Function* function = functionRec->factoryFn(); 746 Function* function = functionRec->factoryFn();
747 function->setArguments(args); 747 function->setArguments(args);
748 function->setName(name); 748 function->setName(name);
749 return function; 749 return function;
750 } 750 }
751 751
752 } 752 }
753 } 753 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimateMotionElement.cpp ('k') | Source/platform/DateComponents.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698