Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Side by Side Diff: Source/core/dom/ContainerNode.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/dom/Range.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 document().nodeWillBeRemoved(child); // e.g. mutation event listener can cre ate a new range. 375 document().nodeWillBeRemoved(child); // e.g. mutation event listener can cre ate a new range.
376 ChildFrameDisconnector(child).disconnect(); 376 ChildFrameDisconnector(child).disconnect();
377 } 377 }
378 378
379 void ContainerNode::willRemoveChildren() 379 void ContainerNode::willRemoveChildren()
380 { 380 {
381 NodeVector children; 381 NodeVector children;
382 getChildNodes(*this, children); 382 getChildNodes(*this, children);
383 383
384 ChildListMutationScope mutation(*this); 384 ChildListMutationScope mutation(*this);
385 for (NodeVector::const_iterator it = children.begin(); it != children.end(); it++) { 385 for (NodeVector::const_iterator it = children.begin(); it != children.end(); ++it) {
386 ASSERT(*it); 386 ASSERT(*it);
387 Node& child = **it; 387 Node& child = **it;
388 mutation.willRemoveChild(child); 388 mutation.willRemoveChild(child);
389 child.notifyMutationObserversNodeWillDetach(); 389 child.notifyMutationObserversNodeWillDetach();
390 dispatchChildRemovalEvents(child); 390 dispatchChildRemovalEvents(child);
391 } 391 }
392 392
393 ChildFrameDisconnector(*this).disconnect(ChildFrameDisconnector::Descendants Only); 393 ChildFrameDisconnector(*this).disconnect(ChildFrameDisconnector::Descendants Only);
394 } 394 }
395 395
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 return true; 977 return true;
978 978
979 if (node->isElementNode() && toElement(node)->shadow()) 979 if (node->isElementNode() && toElement(node)->shadow())
980 return true; 980 return true;
981 981
982 return false; 982 return false;
983 } 983 }
984 #endif 984 #endif
985 985
986 } // namespace WebCore 986 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/dom/Range.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698