Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 14107015: Rename OS(DARWIN) to OS(MACOSX). (Closed)

Created:
7 years, 7 months ago by lgombos
Modified:
7 years, 3 months ago
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, jchaffraix+rendering, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, danakj, Stephen Chennney, aandrey+blink_chromium.org, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename OS(DARWIN) to OS(MACOSX). Currently Mac OS X is the only DARWIN platform supported, so there is no need to make a distinction between OS(DARWIN) and OS(MACOSX). A distinction between OS(DARWIN) and OS(MACOSX) would only make sense if blink would support (e.g. with a running bot) a configuration where where OS(DARWIN) is set but OS(MAC) is not set. Such a configuration is not a project goal currently. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157410

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -218 lines) Patch
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/config.h View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationPolicy.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/Settings.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/LayoutUnit.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/PlatformWheelEvent.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/ScrollAnimator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollAnimator.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/Scrollbar.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/SecureTextInput.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/SecureTextInput.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/audio/Biquad.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/audio/Biquad.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/audio/DirectConvolver.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/audio/FFTFrame.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/audio/FFTFrameStub.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/audio/Reverb.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/audio/VectorMath.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/audio/mac/FFTFrameMac.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/PlatformKeyboardEventChromium.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/FloatPoint.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/FloatRect.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/FloatSize.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/Font.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/Font.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/FontCache.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/FontCustomPlatformData.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/FontDescription.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/FontPlatformData.h View 1 2 13 chunks +18 lines, -18 lines 0 comments Download
M Source/core/platform/graphics/FontPlatformData.cpp View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/platform/graphics/GlyphBuffer.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/GraphicsContext.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/GraphicsContext.cpp View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/IntPoint.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/IntRect.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/IntSize.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/SimpleFontData.h View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/platform/graphics/cocoa/FontPlatformDataCocoa.mm View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/graphics/gpu/DrawingBuffer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/mac/FontMac.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/image-decoders/ImageDecoder.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 2 11 chunks +12 lines, -12 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/ChromeClientImplTest.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/KeyboardTest.cpp View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Assertions.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/AutodrainedPool.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/FastMalloc.cpp View 1 2 13 chunks +13 lines, -13 lines 0 comments Download
M Source/wtf/MathExtras.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/NumberOfCores.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/RandomNumberSeed.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/StringExtras.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/TCSystemAlloc.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/ThreadingPthreads.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/VMTags.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/text/ASCIIFastPath.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/unicode/icu/CollatorICU.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
lgombos
As discussed at https://codereview.chromium.org/14516007/ . This CL will rot fast.
7 years, 7 months ago (2013-04-28 18:55:12 UTC) #1
eseidel
lgtm I would have just called it OS(MAC) to save characters. :)
7 years, 7 months ago (2013-04-28 19:28:29 UTC) #2
lgombos
On 2013/04/28 19:28:29, Eric Seidel (Google) wrote: > lgtm > > I would have just ...
7 years, 7 months ago (2013-04-28 22:32:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14107015/1
7 years, 7 months ago (2013-04-28 22:37:48 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=85
7 years, 7 months ago (2013-04-28 22:53:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14107015/1
7 years, 7 months ago (2013-05-24 08:43:18 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/page/Settings.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-24 08:43:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14107015/14001
7 years, 7 months ago (2013-05-27 04:10:11 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=603
7 years, 7 months ago (2013-05-27 04:20:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14107015/30001
7 years, 3 months ago (2013-09-07 15:07:43 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 16:22:14 UTC) #11
Message was sent while issue was closed.
Change committed as 157410

Powered by Google App Engine
This is Rietveld 408576698