Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed)

Created:
6 years, 10 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, Jói, juberti2, tnakamura
Visibility:
Public.

Description

Reland CL to implement browser-side logging to WebRtc log. This reverts commit d95595eb5145e310baf692f359f9488faf73750d, and it fixes the original bug where |requests_| was being accessed from the UI thread. BUG=338848, 332261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247697

Patch Set 1 : This is the original CL, untouched #

Total comments: 1

Patch Set 2 : These are the changes that should fix crbug.com/338848 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -42 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device_aura_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 4 chunks +17 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 5 chunks +120 lines, -1 line 9 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_impl.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/video/capture/android/video_capture_device_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/mac/video_capture_device_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/video_capture_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vrk (LEFT CHROMIUM)
See diffs in patchset 1 for the diff against r247164. jam: OWNERS rubberstamp (non-media stuff ...
6 years, 10 months ago (2014-01-29 03:06:40 UTC) #1
Henrik Grunell
https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode125 content/browser/renderer_host/media/media_stream_manager.cc:125: base::Unretained(content::BrowserMainLoop::GetInstance() Why is base::Unretained safe when posting on the ...
6 years, 10 months ago (2014-01-29 08:27:04 UTC) #2
jam
lgtm
6 years, 10 months ago (2014-01-29 08:32:37 UTC) #3
Henrik Grunell
LGTM https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode125 content/browser/renderer_host/media/media_stream_manager.cc:125: base::Unretained(content::BrowserMainLoop::GetInstance() On 2014/01/29 08:27:04, Henrik Grunell wrote: > ...
6 years, 10 months ago (2014-01-29 08:53:50 UTC) #4
perkj_chrome
lgtm https://codereview.chromium.org/140633004/diff/1/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/140633004/diff/1/content/browser/renderer_host/media/media_stream_manager.cc#newcode1555 content/browser/renderer_host/media/media_stream_manager.cc:1555: for (DeviceRequests::const_iterator it = requests_.begin(); Sorry- I should ...
6 years, 10 months ago (2014-01-29 09:02:25 UTC) #5
Henrik Grunell
https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode1562 content/browser/renderer_host/media/media_stream_manager.cc:1562: // safe to use base::Unretained. On 2014/01/29 09:02:25, perkj ...
6 years, 10 months ago (2014-01-29 09:49:09 UTC) #6
tommi (sloooow) - chröme
lgtm lgtm. Would be good to get the set<> out of there. https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc ...
6 years, 10 months ago (2014-01-29 10:20:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/140633004/20001
6 years, 10 months ago (2014-01-29 10:20:22 UTC) #8
Henrik Grunell
https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/140633004/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode1562 content/browser/renderer_host/media/media_stream_manager.cc:1562: // safe to use base::Unretained. On 2014/01/29 09:49:10, Henrik ...
6 years, 10 months ago (2014-01-29 10:37:02 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 16:35:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 247697

Powered by Google App Engine
This is Rietveld 408576698