content/browser/renderer_host/media/desktop_capture_device.cc - Issue 140633004: Reland CL to implement browser-side logging to WebRtc log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/desktop_capture_device.cc

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/desktop_capture_device.cc

diff --git a/content/browser/renderer_host/media/desktop_capture_device.cc b/content/browser/renderer_host/media/desktop_capture_device.cc

index 4c84918423d0ce812277a57300b7c4f1d588d96d..74ecd80fbb8db1b1fd20c4c93f56fd546f156c00 100644

--- a/content/browser/renderer_host/media/desktop_capture_device.cc

+++ b/content/browser/renderer_host/media/desktop_capture_device.cc

@@ -165,8 +165,9 @@ void DesktopCaptureDevice::Core::OnCaptureCompleted(

capture_in_progress_ = false;

if (!frame) {

- LOG(ERROR) << "Failed to capture a frame.";

- client_->OnError();

+ std::string log("Failed to capture a frame.");

+ LOG(ERROR) << log;

+ client_->OnError(log);

return;

}