media/video/capture/video_capture_device.h - Issue 140633004: Reland CL to implement browser-side logging to WebRtc log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/video_capture_device.h

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/capture/video_capture_device.h

diff --git a/media/video/capture/video_capture_device.h b/media/video/capture/video_capture_device.h

index c02dcc1a4b4245f5bae5940f42fe842a7fbb8039..a3cabad1e7f2b734d2eeb9d56de1b76685a635ed 100644

--- a/media/video/capture/video_capture_device.h

+++ b/media/video/capture/video_capture_device.h

@@ -180,8 +180,8 @@ class MEDIA_EXPORT VideoCaptureDevice {

int frame_rate) = 0;

// An error has occurred that cannot be handled and VideoCaptureDevice must

- // be StopAndDeAllocate()-ed.

- virtual void OnError() = 0;

+ // be StopAndDeAllocate()-ed. |reason| is a text description of the error.

+ virtual void OnError(const std::string& reason) = 0;

};

// Creates a VideoCaptureDevice object.