Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6245)

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.h

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_logging_handler_host.h
diff --git a/chrome/browser/media/webrtc_logging_handler_host.h b/chrome/browser/media/webrtc_logging_handler_host.h
index 5f7f5a42d699a671b81e65d9c197db6026e276a3..3ce35cb7fabf6c86905b0845f29576ef8b088126 100644
--- a/chrome/browser/media/webrtc_logging_handler_host.h
+++ b/chrome/browser/media/webrtc_logging_handler_host.h
@@ -61,6 +61,9 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter {
// called on the IO thread.
void DiscardLog(const GenericDoneCallback& callback);
+ // Adds a message to the log.
+ void LogMessage(const std::string& message);
+
// May be called on any thread. |upload_log_on_render_close_| is used
// for decision making and it's OK if it changes before the execution based
// on that decision has finished.
@@ -99,9 +102,13 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter {
virtual bool OnMessageReceived(const IPC::Message& message,
bool* message_was_ok) OVERRIDE;
+ // Handles log message requests from both renderer process.
void OnAddLogMessage(const std::string& message);
void OnLoggingStoppedInRenderer();
+ // Handles log message requests from browser process.
+ void AddLogMessageFromBrowser(const std::string& message);
+
void StartLoggingIfAllowed();
void DoStartLogging();
void LogMachineInfo();

Powered by Google App Engine
This is Rietveld 408576698